feat(redis): Support streaming spans by sentrivana · Pull Request #6083 · getsentry/sentry-python

sentrivana · 2026-04-16T07:52:58Z

Description

Support span streaming in the Redis integration(s).

support creating streamed spans
move data and tags to attributes
make sure attributes are in semantic conventions
add tests

The following tags/extra are purposefully left out in the streaming path as they are non-standard and unused:

redis.commands
redis.transaction
redis.is_cluster

The diff size looks terrifying but it's mostly tests 🙏🏻 The actual code changes are very straightforward.

Issues

Closes Migrate redis to span first #6052
Closes PY-2354

Reminders

Please add tests to validate your changes, and lint your code using tox -e linters.
Add GH Issue ID & Linear ID (if applicable)
PR title should use conventional commit style (feat:, fix:, ref:, meta:)
For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

linear-code · 2026-04-16T07:53:03Z

PY-2354 Migrate redis to span first

github-actions · 2026-04-16T07:53:19Z

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

This PR will not appear in the changelog.

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-04-16T07:54:27Z

Codecov Results 📊

✅ 32 passed | Total: 32 | Pass Rate: 100% | Execution Time: 254ms

All tests are passing successfully.

❌ Patch coverage is 9.76%. Project has 16342 uncovered lines.

Files with missing lines (6)

File	Patch %	Lines
`utils.py`	16.67%	⚠️ 70 Missing
`_async_common.py`	0.00%	⚠️ 63 Missing
`caches.py`	17.46%	⚠️ 52 Missing
`_sync_common.py`	19.35%	⚠️ 50 Missing
`queries.py`	21.43%	⚠️ 33 Missing
`redis_cluster.py`	26.47%	⚠️ 25 Missing

Generated by Codecov Action

Parametrize all tracing-related tests in the redis integration with `span_streaming` [True, False] so they exercise both the streaming and legacy (static) trace lifecycles. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Older redis-py versions (e.g. 4.6.0) emit an extra COMMAND span during RedisCluster initialization. Mirror the legacy branch's handling so the streaming assertion tolerates it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

sentry-warden

Missing exception handling around set_db_data_fn and _set_client_data in async client (sentry_sdk/integrations/redis/_async_common.py:147)

In _sentry_execute_command, the calls to set_db_data_fn(db_span, self) and _set_client_data(db_span, is_cluster, name, *args) are not wrapped in capture_internal_exceptions(). The synchronous counterpart in _sync_common.py wraps these calls (lines 147-149). If these functions raise an exception, it will propagate and could cause the Redis command to fail or leave spans unclosed, affecting user operations.

Identified by Warden find-bugs

Co-authored-by: sentry-warden[bot] <258096371+sentry-warden[bot]@users.noreply.github.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b52f66e. Configure here.}

alexander-alderman-webb

LGTM! I haven't read every line of test change but the ones I looked at were good.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

sentrivana added 6 commits April 16, 2026 09:35

redis cluster

5a9efd3

utils

fc29c65

queries

263859c

caches

2bee953

async common

4bc2a5c

sync common

08e896a

sentrivana added the skip-changelog label Apr 16, 2026

sentry-warden Bot reviewed Apr 16, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/redis/_async_common.py

Comment thread sentry_sdk/integrations/redis/_sync_common.py Outdated

sentrivana added 2 commits April 16, 2026 10:42

migrate attrs

f783ecc

.

032c7e2

sentry-warden Bot reviewed Apr 16, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/redis/utils.py Outdated

sentrivana added 3 commits April 21, 2026 13:50

.

ac5b438

Merge branch 'master' into ivana/port-redis-to-span-first

4448a26

.

2eb772e

sentry-warden Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/redis/_sync_common.py

Comment thread sentry_sdk/integrations/redis/utils.py Outdated

sentrivana and others added 2 commits April 22, 2026 16:49

Merge branch 'master' into ivana/port-redis-to-span-first

d046e8a

sentry-warden Bot reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/integrations/redis/cluster_asyncio/test_redis_cluster_asyncio.py

Comment thread tests/integrations/redis/test_redis_cache_module_async.py

sentry-warden Bot reviewed Apr 22, 2026

View reviewed changes

sentrivana added 5 commits April 23, 2026 09:18

unify async and sync

780bcd1

.

3869fad

.

f6cb19d

.

ece5b40

.

46ba738

sentry-warden Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread tests/integrations/redis/asyncio/test_redis_asyncio.py

sentry-warden Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread tests/integrations/redis/test_redis.py Outdated

sentrivana and others added 6 commits April 23, 2026 09:32

Update tests/integrations/redis/test_redis.py

63f00e6

Co-authored-by: sentry-warden[bot] <258096371+sentry-warden[bot]@users.noreply.github.com>

Merge branch 'master' into ivana/port-redis-to-span-first

895f754

.

21bcdbf

.

e9ec242

.

71308a3

thanks for nothing claude

c368f5c

sentrivana marked this pull request as ready for review April 23, 2026 08:03

sentrivana requested a review from a team as a code owner April 23, 2026 08:03

sentry-warden Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread tests/integrations/redis/test_redis.py Outdated

cursor Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/redis/utils.py Outdated

clean up func

b52f66e

cursor Bot reviewed Apr 23, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/redis/modules/queries.py Outdated

alexander-alderman-webb approved these changes Apr 23, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/redis/utils.py Outdated

Use SPANDATA constants instead of hardcoded strings in redis integration

9bfff6e

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

sentrivana enabled auto-merge (squash) April 23, 2026 08:48

sentrivana merged commit aa4378f into master Apr 23, 2026
166 of 168 checks passed

sentrivana deleted the ivana/port-redis-to-span-first branch April 23, 2026 09:17

Conversation

sentrivana commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Reminders

Uh oh!

linear-code Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sentry-warden Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexander-alderman-webb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sentrivana commented Apr 16, 2026 •

edited

Loading

github-actions Bot commented Apr 16, 2026 •

edited

Loading

github-actions Bot commented Apr 16, 2026 •

edited

Loading